Skip to content

VED-1013 Introduce new e2e tests from automation testers#1146

Merged
dlzhry2nhs merged 14 commits intomasterfrom
staging/VED-1011-new-e2e-tests
Jan 22, 2026
Merged

VED-1013 Introduce new e2e tests from automation testers#1146
dlzhry2nhs merged 14 commits intomasterfrom
staging/VED-1011-new-e2e-tests

Conversation

@dlzhry2nhs
Copy link
Copy Markdown
Contributor

@dlzhry2nhs dlzhry2nhs commented Jan 21, 2026

Summary

  • Routine Change

Each of the PRs comprising this staging branch into master have been reviewed and merged. (There are a few misc direct commits but they are all small save for the initial commit from Krupa that copied across the code from the automation testing repository.)

They key changes are as follows:

  • Linting updates to bring the new code into line
  • Project standardisation i.e. use poetry, dependabot, standard Python packaging procedures
  • Added retry behaviour to reduce test flakiness e.g. 502 errors when initially ramping up in the absence of nice controls like you get in other frameworks such as Playwright
  • Replicated status and ping endpoint tests that existed in the old testing suite
  • Added on-demand Apigee apps which allow us to test in PR environments, and make the whole process smoother
  • Updated the pipeline action so that all relevant pipelines now execute the new tests and deleted all the old content.

Reviews Required

  • Dev
  • Test

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all of the acceptance criteria of the ticket.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • If there were changes that are outside of the regular release processes e.g. account infrastructure to setup, manual setup for external API integrations, secrets to set, then I have checked that the developer has flagged this to the Tech Lead as release steps.
  • I have checked that no Personal Identifiable Data (PID) is logged as part of the changes.

Krupasindhu Baral and others added 10 commits January 20, 2026 17:12
* initial commit for automation end to end tests

* Fix linting to meet baselines

* Ignore Allure reports and run prettier checks

* Fix up README

* Sonarcloud advice

* init: project & makefile

* cleanup test results

* full SHAs

* TEMP: exclude tests/e2e_automation/ from ruff

* Minor fixes and ignores

* TEMP: exclude tests/e2e_automation/ from ruff

* revert temp excludes

* init: yml changes

* dependabot

* reverted changes

* make smoke-test

* reverted

* README

* README II

* README III

* .env.example

* .env.example II

* Makefile

* .gitignore

* pyproject.toml

* .env.example III

* .env.example IV

---------

Co-authored-by: Krupasindhu Baral <krupasindhu.baral@nhs.net>
Co-authored-by: Daniel Yip <daniel.yip4@nhs.net>
@github-actions
Copy link
Copy Markdown
Contributor

This branch is working on a ticket in the NHS England VED JIRA Project. Here's a handy link to the ticket:

VED-1011

@dlzhry2nhs dlzhry2nhs temporarily deployed to internal-dev-sandbox January 21, 2026 16:24 — with GitHub Actions Inactive
@dlzhry2nhs dlzhry2nhs changed the title VED-1013 Introduce new e2e tests from automaton testers VED-1013 Introduce new e2e tests from automation testers Jan 21, 2026
@dlzhry2nhs dlzhry2nhs temporarily deployed to internal-dev-sandbox January 21, 2026 16:27 — with GitHub Actions Inactive
Comment thread tests/e2e_automation/README.md Outdated
edhall-nhs
edhall-nhs previously approved these changes Jan 21, 2026
Copy link
Copy Markdown
Contributor

@edhall-nhs edhall-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One pedantic and optional comment but otherwise looks great. Very well laid out and clearly explained in the README 👍

@sonarqubecloud
Copy link
Copy Markdown

@dlzhry2nhs dlzhry2nhs merged commit 8f10986 into master Jan 22, 2026
16 checks passed
@dlzhry2nhs dlzhry2nhs deleted the staging/VED-1011-new-e2e-tests branch February 2, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants